PluginBench
Skill
Pass
Audit score 90

python-design-patterns

wshobson/agents

Write maintainable Python code using KISS, Single Responsibility, Separation of Concerns, and composition over inheritance.

What is python-design-patterns?

A guide to fundamental Python design principles for building systems that are easy to understand, test, and modify. Use this skill when designing new components, refactoring complex code, choosing between inheritance and composition, or evaluating code for coupling and testability issues.

  • Apply KISS principle to choose simplest working solutions
  • Enforce Single Responsibility by separating concerns into focused components
  • Use composition over inheritance for flexible behavior
  • Apply Rule of Three before abstracting duplicated code
  • Inject dependencies through constructors for testability
  • Maintain shallow composition hierarchies to avoid complexity

How to install python-design-patterns

npx skills add https://github.com/wshobson/agents --skill python-design-patterns
Claude Code
Cursor
Windsurf
Cline

How to use python-design-patterns

  1. 1.Identify the core concern or responsibility of your component
  2. 2.Apply the 'reason to change' test to detect multiple responsibilities
  3. 3.Choose composition over inheritance for new abstractions
  4. 4.Use constructor dependency injection to enable testing
  5. 5.Keep functions small (20-50 lines) with single purpose
  6. 6.Wait for three instances before abstracting (Rule of Three)
  7. 7.Maintain clear layer boundaries with downward-pointing dependencies

Use cases

Good for
  • Designing a new service or component from scratch and choosing how to layer responsibilities
  • Refactoring a God class or monolithic function that has grown too large
  • Deciding whether to add a new abstraction or accept duplication
  • Evaluating pull requests for structural issues like tight coupling or leaking internal types
  • Choosing between inheritance and composition for a new class hierarchy
Who it's for
  • Python developers designing new systems
  • Teams refactoring legacy code
  • Code reviewers evaluating architecture
  • Engineers building modular, testable services

python-design-patterns FAQ

When should I abstract duplicated code?

Apply the Rule of Three: wait until you have three instances before abstracting. However, if duplication is already causing bugs when one copy is updated but not others, abstract immediately and add tests for the shared behavior.

How do I know if a class has too many responsibilities?

Use the 'reason to change' test: list every change that could require editing the class. If items come from different domains (HTTP parsing, business rules, formatting), split it. If all changes stem from one domain concern, the class is appropriately sized.

My constructor has 7+ parameters from dependency injection. Is this a problem?

This signals too many responsibilities in one class, not a problem with dependency injection. Split the class into smaller units first; each constructor will naturally become smaller.

How deep should composition chains be?

Keep composition shallow (2-3 levels). If wrapping becomes the only mechanism and chains get deep, consider Protocol-based approaches or simple function composition instead.

How do I fix layering violations like a service importing from the API layer?

Introduce a shared types/models layer that both can import from, keeping the dependency arrow pointing downward (API → Service → Repository).

Full instructions (SKILL.md)

Source of truth, from wshobson/agents.


name: python-design-patterns description: Python design patterns including KISS, Separation of Concerns, Single Responsibility, and composition over inheritance. Use this skill when designing a new service or component from scratch and choosing how to layer responsibilities, when refactoring a God class or monolithic function that has grown too large, when deciding whether to add a new abstraction or live with duplication, when evaluating a pull request for structural issues like tight coupling or leaking internal types, when choosing between inheritance and composition for a new class hierarchy, or when a codebase is becoming hard to test because of entangled I/O and business logic.

Python Design Patterns

Write maintainable Python code using fundamental design principles. These patterns help you build systems that are easy to understand, test, and modify.

When to Use This Skill

  • Designing new components or services
  • Refactoring complex or tangled code
  • Deciding whether to create an abstraction
  • Choosing between inheritance and composition
  • Evaluating code complexity and coupling
  • Planning modular architectures

Core Concepts

1. KISS (Keep It Simple)

Choose the simplest solution that works. Complexity must be justified by concrete requirements.

2. Single Responsibility (SRP)

Each unit should have one reason to change. Separate concerns into focused components.

3. Composition Over Inheritance

Build behavior by combining objects, not extending classes.

4. Rule of Three

Wait until you have three instances before abstracting. Duplication is often better than premature abstraction.

Quick Start

# Simple beats clever
# Instead of a factory/registry pattern:
FORMATTERS = {"json": JsonFormatter, "csv": CsvFormatter}

def get_formatter(name: str) -> Formatter:
    return FORMATTERS[name]()

Detailed patterns and worked examples

Detailed pattern documentation lives in references/details.md. Read that file when the navigation tier above is insufficient.

Best Practices Summary

  1. Keep it simple - Choose the simplest solution that works
  2. Single responsibility - Each unit has one reason to change
  3. Separate concerns - Distinct layers with clear purposes
  4. Compose, don't inherit - Combine objects for flexibility
  5. Rule of three - Wait before abstracting
  6. Keep functions small - 20-50 lines (varies by complexity), one purpose
  7. Inject dependencies - Constructor injection for testability
  8. Delete before abstracting - Remove dead code, then consider patterns
  9. Test each layer - Isolated tests for each concern
  10. Explicit over clever - Readable code beats elegant code

Troubleshooting

A class is growing and seems to have multiple responsibilities, but splitting it feels wrong. Apply the "reason to change" test: list every change that could require editing this class. If the list has items from different domains (e.g., HTTP parsing AND business rules AND formatting), split it. If all changes stem from the same domain concern, the class may be appropriately sized.

Injecting all dependencies through the constructor is producing constructors with 7+ parameters. This is a sign of too many responsibilities in one class, not a problem with dependency injection. Split the class into smaller units first, then each constructor naturally becomes smaller.

Composition is producing deeply nested wrapper objects that are hard to trace. Keep the composition shallow (2-3 levels). If wrapping is the only mechanism, consider whether a Protocol-based approach or simple function composition would be cleaner than a chain of decorator objects.

The rule of three says not to abstract yet, but the duplication is causing bugs when one copy is updated but not the other. Duplication that diverges in dangerous ways should be abstracted sooner. The rule of three is a heuristic, not a law. If the copies are already diverging incorrectly, extract immediately and add a test that exercises the shared behavior.

A service layer is importing from the API layer, breaking the dependency direction. This is a layering violation. The service layer must not import from handlers. Introduce a shared types/models layer that both can import from, keeping the dependency arrow pointing downward (API → Service → Repository).

Related Skills

  • python-testing-patterns — Test each layer in isolation using the dependency injection structure established here
  • python-project-setup — Set up project structure and tooling that enforces layer boundaries from the start